knocknarea / fastlane-plugin-ionic_integration

Integrating Fastlane and Ionic or Cordova Generated Projects
MIT License
26 stars 15 forks source link

Your './fastlane/ionic/config/ios/ui-tests/ionic-screen-shots/SnapshotHelper.swift' is outdated, please run `fastlane snapshot update` #5

Open janpio opened 7 years ago

janpio commented 7 years ago

While running the lane from the README for the first time I get this:

[04:28:30]: Your './fastlane/ionic/config/ios/ui-tests/ionic-screen-shots/SnapshotHelper.swift' is outdated, please run `fastlane snapshot update`
[04:28:30]: to update your Helper file
+---------------+--------------+
|         Lane Context         |
+---------------+--------------+
| PLATFORM_NAME | ios          |
| LANE_NAME     | ios snapshot |
+---------------+--------------+
[04:28:32]: Please update your Snapshot Helper file

+------+---------------------+-------------+
|             fastlane summary             |
+------+---------------------+-------------+
| Step | Action              | Time (in s) |
+------+---------------------+-------------+
| 1    | Verifying required  | 0           |
|      | fastlane version    |             |
| 💥   | snapshot            | 72          |
+------+---------------------+-------------+

[04:28:32]: fastlane finished with errors

[!] Please update your Snapshot Helper file

The version in /fastlane indeed seems to be version 1.4 while the generated one is version 1.3, the difference is one line almost at the end.

Copying the changes over manually fixed this error for now.

knocknarea commented 7 years ago

@janpio Would you mind adding this to the PR fixes for the project name also? I am not available to make those changes myself.

janpio commented 7 years ago

I can submit a PR just for this one. But maybe this should be handles in some other way that doesn't require this file to be present in this repo/plugin? It does come from somewhere...

knocknarea commented 7 years ago

Yes actually, it is manually copied from here: https://github.com/fastlane/fastlane/blob/master/snapshot/lib/assets/SnapshotHelper.swift