functionRewrite improvements

knockout / tko

🥊 Technical Knockout – The Monorepo for Knockout.js (4.0+)

http://www.tko.io

Other

273 stars 34 forks source link

functionRewrite improvements #150

Closed danieldickison closed 2 years ago

danieldickison commented 2 years ago

strip trailing semicolon from function body
make return optional for side-effects-only functions
log the args when rewriting
include the binding text in error messages for any remaining deprecated function bindings so that these can be located more easily in the source

danieldickison commented 2 years ago

I'm not sure how to fix the Polynomial regular expression used on uncontrolled data issue, but I don't think it really matters because we’re only parsing bindings written by the site developer, not those entered by end users.

danieldickison commented 2 years ago

@brianmhunt I figure undefined should be safe with the browsers we now support.

I don't have permissions on the repo so please merge it upstream. Thanks!