knockout / tko

🥊 Technical Knockout – The Monorepo for Knockout.js (4.0+)
http://www.tko.io
Other
273 stars 34 forks source link

Make Identifier.set_value work with inherited properties #157

Closed danieldickison closed 2 years ago

danieldickison commented 2 years ago

bindingContext.lookup works with properties that are inherited through an object's prototype chain, but Identifer.set_value does not, which leads to asymmetrical behavior with bindings that read/write to an observable that’s inherited. This PR updates Identifier.set_value so that it works with inherited properties, in line with how knockout works.