observable) replace `objectLookup` with canonical `Map`

knockout / tko

🥊 Technical Knockout – The Monorepo for Knockout.js (4.0+)

http://www.tko.io

Other

273 stars 34 forks source link

observable) replace `objectLookup` with canonical `Map` #171

Closed brianmhunt closed 2 years ago

brianmhunt commented 2 years ago

Change the custom, archaic objectLookup type to a Map. This can have dramatic performance increase as it changes the computational complexity of toJS from O(n²) to O(n) over the object/array size.

Closes #170

brianmhunt commented 2 years ago

@danieldickison @mbest I'd be grateful for a sanity review/approval here, if you have a moment.

brianmhunt commented 2 years ago

@felipesantoz Tagging for visibility.