search

knockout / tko

🥊 Technical Knockout – The Monorepo for Knockout.js (4.0+)
http://www.tko.io
Other
274 stars 34 forks source link

Support JSS for styles #66

Open brianmhunt opened 6 years ago

brianmhunt commented 6 years ago

With JSX (#25) and jss we should be able to fully compartmentalize the code for components.

I'm hoping to get this in for Beta-1, since once we're done catching TKO up to the mainline branch, this is relatively low hanging fruit.

Thoughts @knockout/core @knockout/extended ?

mbest commented 6 years ago

JSS looks cool. Related: knockout/knockout#1692

brianmhunt commented 6 years ago

JSS supports TC39 (#22) observables, so I'd argue to properly get jss support we'd want TC39. Experimenting now.

avickers commented 5 years ago

If this is still a stumbling block, you could consider going with Constructable Style Sheets instead of JSS. They are live in Chrome, and Jason Miller made an attempt at a tiny polyfill, which appeared to work in FF and Safari when I tried it.

Followup: So, it turns out that, while replaceSync() worked as expected, I got weird errors about illegal characters when trying to use replace() with the polyfill.