search

knod / read_plugin

Chrome plugin for "read"
9 stars 8 forks source link

Pause + arrows = wrong direction #58

Closed knod closed 7 years ago

knod commented 7 years ago

For commit 6f1e8b60904d09a1f062feadd9265aa2c38b8cc7: When Readerly is paused and the user presses the right or left arrow, the scrubber travels in the wrong direction for one step. If the same arrow is pressed again, the scrubber/text travel goes in the direction it should have been going in the first place. If the other direction is pressed, the scrubber is again sent the wrong way. This happens either with or without the modifier key. Also, the behavior is the same even if a modifier is first held down and then not or visa versa.

knod commented 7 years ago

After more experimentation, it seems that the text is behaving like it should, it's just the progress bar that's behaving this way. With the input described above, the handle appears to go forward when the text goes backward and visa versa.

Also, this doesn't happen the first time an arrow key is pressed, only the times after that. The behavior does not reset after playing and pausing again.

Edit: open a new issue for the speed problem That may just be in the currently edited version, not in the commit mentioned, but for some reason the delay between words has greatly increased no matter what settings are used, though the speed is still affected by the settings.

knod commented 7 years ago

Turns out we were changing progress appearance at the beginning of the playback loop instead of the end :P