search

knod / read_plugin

Chrome plugin for "read"
9 stars 8 forks source link

make settings window height work well in big screen sizes #64

Closed synapse25 closed 7 years ago

knod commented 7 years ago

Currently, sizing and scrolling work well for small windows, but with big windows the settings element stays short and requires scrolling, even though there's plenty of room to fit in in the window.

knod commented 7 years ago

Fixed with complex resizing in js. Not sure when. Made this demo in the construction of the solution, though: https://jsfiddle.net/fpd4fb80/31/ (this link should appear in the commit at around the same time as the problem was solved).

The function that handles this change in height must be used carefully. If used inappropriately it will prevent the app from appearing at all. More work is needed to make it more robust, but it works and that's enough for now.

Note: Look into flexbox poly-fills