knokko / custom-items-gradle

Knokko's Custom Items: Add custom items to your server, completely free of charge
MIT License
15 stars 3 forks source link

Bedrock conflict #184

Closed Insidi0usAngel closed 2 years ago

Insidi0usAngel commented 2 years ago

I am using Geyser-spigot + Floodgate to allow bedrock users onto my server. It is normal for bedrock users to not be able to see custom textures/resource packs for Java server and use such items, however, having custom items plugin + knokko core on the server has caused a conflict with the bedrock player whereby the crafting table does not hold recipes, ie if you click on make an iron chestplate the iron ingots flash on and off and leave an empty crafting table, if you want to craft something complex like a sea lantern and don't know the recipe then the bedrock user cannot make the item as it changed the crafting table in such a way as they can only use it if they drag and drop individual items into crafting slots. On disabling custom items plugin + knokko core the issue for bedrock players with crafting table was fixed. I hope there can be a fix for this at a future point as your plugin was easy to use and offered a lot of creativity and potential.

I see this is already reported on bedrock issues, but to add a bit more detail - this issue occurs on all bedrock platforms - pc and mobile phone.

knokko commented 2 years ago

What happens when you try this custom version of custom items? https://github.com/knokko/custom-items-gradle/files/8543292/ThisContainsCustomItems.jar.zip Does that solve (part of) the problem?

Insidi0usAngel commented 2 years ago

Just added the above Jar you sent me and knokko core back to plugins and I can confirm now this fixes all issues with the crafting table!! Thank you so much, did not expect you to fix it so fast !

On Tue, 5 Jul 2022 at 19:30, Tim @.***> wrote:

What happens when you try this custom version of custom items?

https://github.com/knokko/custom-items-gradle/files/8543292/ThisContainsCustomItems.jar.zip Does that solve (part of) the problem?

— Reply to this email directly, view it on GitHub https://github.com/knokko/custom-items-gradle/issues/184#issuecomment-1175365922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXV3BXMZYFRLWRY3CF6LVPDVSR5MHANCNFSM52WNTOHQ . You are receiving this because you authored the thread.Message ID: @.***>

knokko commented 2 years ago

I was quick because someone else reported the same behavior before: https://github.com/knokko/custom-items-gradle/issues/160 This time, I should not forget to include this fix in the regular versions.

BobtheBob123456 commented 2 years ago

I can confirm. This is is the same glitch that happened to me.

Insidi0usAngel commented 2 years ago

All the same support has been excellent so I gave your plugin a 5 star rating. I have a new discovery though which has only just happened in the last couple days and I think I know the reason why... I was trouble shooting a number of bedrock compatibility issues on the same day - basically my server was previously using the pebblehost auto-updating 1.19 jar (which did not conflict with your plugin at all) but this was the culprit of a chests issue, on replacing the .jar with the most recent official paper mc version which fixed a bedrock incompatibility (paper version 50 onwards now using #56) I started getting a new error warning with your plugin - see attachment... But this in itself seems to be a non-problem - there are no error messages in console other than warning about not using crazy enchantments etc, and after adding 2 custom items onto my server today these items had full functionality - so other than getting a message that the server jar file is not supported by knokko there is no actual error - everything works and no console spam/no ram leaks/no loss of functionality etc.... I have installed another 2 plugins (not yet configured) which potentially could cause conflict but I doubt it as it seems to reference specifically not liking my server version since i updated the paper.jar. I don't know if you are already aware of this issue and so let me know if you want it posting as a bug for your to do list, as its only cosmetic it should be low on your priority list.

Thanks for making such an amazing plugin, it is so much fun to make these custom items and then see them in action !!!

On Wed, 6 Jul 2022 at 07:32, Tim @.***> wrote:

I was quick because someone else reported the same behavior before: #160 https://github.com/knokko/custom-items-gradle/issues/160 This time, I should not forget to include this fix in the regular versions.

— Reply to this email directly, view it on GitHub https://github.com/knokko/custom-items-gradle/issues/184#issuecomment-1175833834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXV3BXJB436Q4YXJ2NKRZTDVSUR7FANCNFSM52WNTOHQ . You are receiving this because you authored the thread.Message ID: @.***>

knokko commented 2 years ago

Which attachment? I don't think your message has any attachments.

Insidi0usAngel commented 2 years ago

Attachment should show, it's on my sent message history, here is the attachment again and if that does not work then try: https://www.dropbox.com/s/j8al2pu8vwgjecb/ci-message.jpg?dl=0

On Fri, 8 Jul 2022 at 21:48, Tim @.***> wrote:

Which attachment? I don't think your message has any attachments.

— Reply to this email directly, view it on GitHub https://github.com/knokko/custom-items-gradle/issues/184#issuecomment-1179349523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXV3BXOS24RLQQMROLFMOILVTCH23ANCNFSM52WNTOHQ . You are receiving this because you authored the thread.Message ID: @.***>

knokko commented 2 years ago

Install Custom Items 10.5 or later to get rid of that warning. EDIT: Never mind, CI 10.5 of course doesn't contain the Bedrock fix... You will need to wait until I publish the next version.

knokko commented 2 years ago

This fix is included in Custom Items 10.8