search

knokko / custom-items-gradle

Knokko's Custom Items: Add custom items to your server, completely free of charge
MIT License
14 stars 3 forks source link

IAE upon removing ingredient of manual container upgrade recipe #298

Closed knokko closed 4 months ago

knokko commented 4 months ago 
[23:11:47 WARN]: [CustomItems] Task #205535 for CustomItems v12.6 generated an exception
java.lang.IllegalArgumentException: Ingredient in slot item is null
        at nl.knokko.customitems.plugin.container.ContainerRecipeWrapper.convertResultToItemStack(ContainerRecipeWrapper.java:42) ~[CustomItems.jar:?]
        at nl.knokko.customitems.plugin.container.ContainerRecipeWrapper.getManualOutput(ContainerRecipeWrapper.java:28) ~[CustomItems.jar:?]
        at nl.knokko.customitems.plugin.container.ContainerInstance.updatePlaceholders(ContainerInstance.java:920) ~[CustomItems.jar:?]
        at nl.knokko.customitems.plugin.container.ContainerInstance.update(ContainerInstance.java:1071) ~[CustomItems.jar:?]
        at java.util.HashMap$Values.forEach(HashMap.java:1073) ~[?:?]
        at nl.knokko.customitems.plugin.data.PluginData.updateContainers(PluginData.java:593) ~[CustomItems.jar:?]
        at nl.knokko.customitems.plugin.data.PluginData.update(PluginData.java:400) ~[CustomItems.jar:?]
        at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.20.1.jar:git-Paper-196]
        at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:480) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1479) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1393) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1170) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317) ~[paper-1.20.1.jar:git-Paper-196]
        at java.lang.Thread.run(Thread.java:1583) ~[?:?]

It looks like I should call updatePlaceholders() only right after determining the current recipe.