search

knolleary / pubsubclient

A client library for the Arduino Ethernet Shield that provides support for MQTT.
http://pubsubclient.knolleary.net/
MIT License
3.78k stars 1.46k forks source link

Future of this module #1045

Open knolleary opened 3 months ago

knolleary commented 3 months ago

I haven't been paying this code the attention it deserves. The issues and PRs have built up to the point where there are lots of duplicates and stale issues.

The code is pretty much in maintenance mode - I'm not looking to add new features etc. But if there are bugs, we should get them fixed.

My rough plan is:

  1. Identify a minimal set of PRs needed to address the most common issues - compiler warnings etc
  2. Close off all 'old' issues and PRs
  3. Publish a new version of the module
  4. Update the README to reflect the general 'maintenance' mode of this module
dominicdumont commented 3 months ago

Just wanted to mention that this is the best library around for pub/sub. It is very useful and I am grateful that you are still willing to maintain it. Thanks for the great work!

hmueller01 commented 3 months ago

I scanned all the PR's and would approve to integrate the following fixes:

  1. All the same, would take the first/oldest: #788, #826, #899, #1005 or #1031
  2. IMPORTANT #783 - closes #747, #1020, #745

  3. 1038

  4. 1029

  5. 1001 - if @feedehc accepts my suggestion (or you do it)

  6. 993, #863 can be closed with this as well

  7. 844

  8. 605

  9. 567 - closes #901, #314

  10. 1046, closes #840

This is potentially worth checking for integration (not adding new features):

  1. 1026

  2. 966

  3. 835

  4. 830

  5. 768

kamiKAZIK commented 3 months ago

would it make sense to create an organization and assign several maintainers instead? This is the best MQTT client for Arduino and ESP as far as I know, would be a shame to slowly put it to rest

hmueller01 commented 3 months ago

I merged almost all patches above, except #1029, #1026 and #835 into https://github.com/hmueller01/pubsubclient/tree/dev-fixes If you like you can test it. I tested this on ESP8266 and found no issues til now. Not sure if #768 works on all platforms, as it uses printf which is not defined in default Arduino

cchaz003 commented 3 months ago

@hmueller01 I'm trying out your changes on some of my deployed devices (the non-critical ones at least). I'll let you know if I run into any bugs related to the merged updates.

@kamiKAZIK I too would love to see some form of a community support moving forward if @knolleary is on board. I've used this lib under the hood on essentially every MQTT based project I've done over the years and would love to give back. I would be happy to join with a group of like minded folks who want this library to live on and continue developing it!

abdosn commented 2 months ago

I suggest using Issue template like this to clean up issues that do not need any updates to the library

Avamander commented 2 months ago

I've been a maintainer for a handful of projects, Arduino and related, for a bunch of years now. If there's interest I can lend a hand when I can.