Refactorings

[mykeul]

Hi, I'm using a refactored version of the library since a couple of years. Some of these refactorings may be merged if you wish. They are available in my fork here : https://github.com/mykeul/pubsubclient/ Please let me know which ones looks good to you : then I'll open a PR containing only the accepted ones. Regards, Mickaël

[knolleary]

Hi,

To be honest I'm not going to study your branch to try to identify what refactorings you've made. If you wanted to provide a list, including the benefit each brings, that would be a more helpful starting point.

[mykeul]

Ok, here's the list :

• 1 : a few private methods are mixed with members making code harder to read (so moved them out of the members)
• 2 : reduced includes in the header file (removed Arduino.h after moving from boolean to bool)
• 3 : reduced includes in the header file (added forward declarations to remove Client.h and Steam.h)
• 4 : useless copies of the IPAddress arguments are made due to the method signatures (moved them to "const IPAddress&" to avoid copies)
• 5 : reduced the large number of constructors to a single one : PubSubClient(Client& client, Stream& stream)
• 6 : switched member "_client" to a reference (since 5, by construction, we have a valid Client that can't be NULL)
• 7 : switch member "stream" (and renamed it to "_stream") to a reference (like for 6 it can't be NULL)

I guess that 5 may be harder to accept because of the interface changes, but it removes lots of duplicated code, and makes the client code clearer by calling the right setters.