Open mykeul opened 6 years ago
Hi,
To be honest I'm not going to study your branch to try to identify what refactorings you've made. If you wanted to provide a list, including the benefit each brings, that would be a more helpful starting point.
Ok, here's the list :
I guess that 5 may be harder to accept because of the interface changes, but it removes lots of duplicated code, and makes the client code clearer by calling the right setters.
Hi, I'm using a refactored version of the library since a couple of years. Some of these refactorings may be merged if you wish. They are available in my fork here : https://github.com/mykeul/pubsubclient/ Please let me know which ones looks good to you : then I'll open a PR containing only the accepted ones. Regards, Mickaël