Open BatmanAoD opened 1 month ago
I've been doing a ton of refactoring of the version handling code to pull out a bunch of stuff into a standalone crate (so the bot can use it). I'm sure I broke something in all that.
Curious—does it pick the right version when actually running PrepareRelease
? It might just be the --dry-run
handling that got broken.
I'm not sure -- if I have some time I'll try to put together a standalone reproduction case.
Oh, but I think I did actually discover this when a release ran, rather than by doing a prerelease.
@BatmanAoD 0.17 finally finishes all the refactor work I was doing in the 0.16 series. Did I happen to fix the version variable bug as part of that?
It appears that this is a bug introduced in either
0.16.1
or0.16.2
.Here, I have several
Command
steps, some of which use theVersion
variable. I've used...
to elide some output. Note that with0.16.0
, therelease-cli
command usesv1.17.0
, but with0.16.2
, the command usesv1.16.0
.Also of interest, despite the
--verbose
flag, the second version-resolution doesn't actually print any output with0.16.2
, even though it does with0.16.0
.