search

knopflerfish / knopflerfish.org

Knopflerfish OSGi Service Platform. OSGi run-time container and SDK source code repo
http://www.knopflerfish.org
BSD 3-Clause "New" or "Revised" License
33 stars 11 forks source link

Issue 58 #60

Closed d3bjorn closed 2 years ago

d3bjorn commented 2 years ago

Http Server: threads created in transactions increase activeCount and server will eventually stop processing requests https://github.com/knopflerfish/knopflerfish.org/issues/58

d3bjorn commented 2 years ago

Copyright year should be updated.

I thought I did that. Did I miss some file?

Why is there a System.out.println("starting up"); in the SocketListener, change to log.info ?

"Someone" put it there in 2015. ;) I guess we could clean up classes that we're editing anyway. I'll fix some obvious things in SocketListener.

chlarsson commented 2 years ago

Copyright in the HttpCommandGroup.java wasn't updated

Also change minor version of bundle. I think the fix qualifies for that.

d3bjorn commented 2 years ago

Bundle version updated.

Copyright in HttpCommandGroup.java was updated in stringbuffer-to-builder merge.

chlarsson commented 2 years ago

Since 5.3.0 is not part of any release, the model in KF has been to only bump bundle versions once inbetween releases, and not for every fix / commit. So I suggest we go should leave it at 5.3.0.