knopkem / dicomweb-pacs

Easy to use DICOMWEB enabled PACS with DIMSE services based on sqlite database
Other
101 stars 38 forks source link

Its works #66

Closed afrovita closed 1 year ago

afrovita commented 1 year ago

image Thanks for your greats work. Question about patient name not showing on the table is that related to OHIF viewer or the DICOM metadata from the PACS? image

knopkem commented 1 year ago

Hi, which version of OHIF is this?

afrovita commented 1 year ago

Preinstalled OHIF DICOM Web Viewer (version 4.12.50) via git clone the repo

afrovita commented 1 year ago

its in StudyListRoute.js OHIF viewer file, change it from const mappedStudies = studies.map(study => { const PatientName = typeof study.PatientName === 'string' ? study.PatientName : undefined; to const mappedStudies = studies.map(study => { const PatientName = typeof study.PatientName[0].Alphabetic === 'string' ?study.PatientName[0].Alphabetic : undefined;

Thank you for your greats works and time

knopkem commented 1 year ago

Thanks for the investigation. It's strange that the patient name is not read correctly as it (was) written in the dicom standard (at least some years ago. Will study it again and come with a fix.

knopkem commented 1 year ago

Actually it seems that this is related to an issue with the native library on linux (using gcc compiler), see: https://github.com/knopkem/dicom-dimse-native/issues/47 So in short, while your fix works, it's only a workaround for a wrong behavior. Will try to fix this correctly. (which is why I reopend the issue)

knopkem commented 1 year ago

The Empty Name issue should be fixed now with version 1.4.1, so you don't need your modifications anymore