search

knorby / facterpy

Python library to provide a cached and dictionary-like interface to Puppet's facter utility
BSD 2-Clause "Simplified" License
8 stars 4 forks source link

replace yaml.load with yaml.safe_load #11

Closed sreerajkksd closed 3 years ago

sreerajkksd commented 3 years ago

yaml.load now issue the following warning:

  In [1]: import facter
  In [2]: facts_helper = facter.Facter()
  In [3]: facts = facts_helper.all
  /usr/local/python/python-3.7/latest/lib64/python3.7/site-packages/facter/__init__.py:81: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
    parsed_results = yaml.load(results)

It is a single line change to fix.

I don't mind raising a PR, but @knorby Can you apply it and release it as a new version ?

knorby commented 3 years ago

@sreerajkksd send a PR, and I can cut a new release

sreerajkksd commented 3 years ago

Here you go: https://github.com/knorby/facterpy/pull/12

sreerajkksd commented 3 years ago

@knorby would you approve and merge this ?

sreerajkksd commented 3 years ago

@knorby Would you please cut a new release ? (and deploy a version in pypi)

sreerajkksd commented 2 years ago

@knorby Can you cut a new release ?