knossos-project / knossos

KNOSSOS is a software tool for the visualization and annotation of 3D image data and was developed for the rapid reconstruction of neural morphology and connectivity.
https://knossos.app
GNU General Public License v2.0
72 stars 18 forks source link

Disable node editing in review mode #441

Closed my-tien closed 6 years ago

my-tien commented 6 years ago

Can select nodes or change active node.

Tree edits still possible, e.g. merging, moving nodes between trees.

Optiligence commented 6 years ago

Tree edits still possible, e.g. merging, moving nodes between trees.

Intentional or just missing?

my-tien commented 6 years ago

Intentional, because there exists no AnnotationMode::TreeEditing atm.

Optiligence commented 6 years ago

is there a reason to distinguish between node and tree editing?

my-tien commented 6 years ago

Well, maybe you want to open a lot of files for review and then want to remove some without clearing the whole skeleton again. In these cases you’d want to be able to delete trees.

Optiligence commented 6 years ago

Maybe? Because i would currently put everything under SkeletonEditing, but we can also add TreeEditing.

my-tien commented 6 years ago

Maybe not maybe. I did that :P