Applied most suggested changes proposed by clang-tidy

knossos-project / knossos

KNOSSOS is a software tool for the visualization and annotation of 3D image data and was developed for the rapid reconstruction of neural morphology and connectivity.

https://knossos.app

GNU General Public License v2.0

73 stars 19 forks source link

Applied most suggested changes proposed by clang-tidy #468

Closed al3xst closed 6 years ago

al3xst commented 6 years ago

Qt Creator 4.6 includes the clang-tidy [1] plugin.

The changes were made with the following settings enabled:

clang-analyzer-*
clang-diagnostic-*
modernize-*
performance-*
readability-*

Not all proposed changes where implemented, since some would break the functionality.

[1] - http://clang.llvm.org/extra/clang-tidy/

Optiligence commented 6 years ago

does it give you rationale when you run it?

al3xst commented 6 years ago

In general you get a brief explanation and of course it offers you to auto fix the issue. But there are cases, where it just tells you what the auto fix will do, without any further explanation.