knossos-project / knossos_utils

Python library for interacting with KNOSSOS data sets and annotation files
GNU General Public License v2.0
9 stars 9 forks source link

Python 3.4+ support, setup/packaging improvements, port to PyQt5 #11

Closed mdraw closed 7 years ago

mdraw commented 8 years ago

Dear KNOSSOS team,

I'd like to eventually merge this branch into master, but before that, it needs some more real-life testing. It would help a lot if you could test some of your known-to-be-working code against my branch by installing it via

$ git clone https://github.com/knossos-project/knossos_python_tools --branch=py3-compat
$ cd knossos_python_tools
$ python2 -m pip install .
$ python2 -m pip install knossos_cuber
$ python3 -m pip install .
$ python3 -m pip install knossos_cuber

and running it (making sure that you don't have any package contents on some custom PYTHONPATH, of course!). Priority right now is to test if knossos_utils on Python 2.7 and knossos_cuber work the same as before. Second Priority is that everything actually works on Python 3.4, 3.5 (and 3.6).

Some notes about what has changed:

Once this is merged, I can publish and maintain packages for knossos_utils and knossos_cuber on https://pypi.org/ and http://anaconda.org/ (maybe via https://conda-forge.github.io/#about).

Please do not merge this branch yet. I will do it once we are sure no regressions have been introduced by it.

mdraw commented 8 years ago

If no one complains, I will merge this in about 1-2 weeks.