search

knowark / facturark

Facturación Electrónica en Python
GNU Lesser General Public License v3.0
3 stars 4 forks source link

lxml version #21

Open blaggacao opened 5 years ago

blaggacao commented 5 years ago

Given that odoo (v12) specs lxml like so:

lxml==3.7.1 ; sys_platform != 'win32' and python_version < '3.7'
lxml==4.2.3 ; sys_platform != 'win32' and python_version >= '3.7'

and facturark specs like so:

lxml==4.2.5

Would facturark work with lxml>=3.7.1?

blaggacao commented 5 years ago

Note: debian:strech, the standard odoo distro, ships with python3.5 by default, so a default environment would have lxml==3.7.1

blaggacao commented 5 years ago

Also odoo (v12) specs qrcode as qrcode==5.3 while facturark specs as qrcode==6.0

blaggacao commented 5 years ago

As per the changelog, qrcode shouldn't be a problem, tough

blaggacao commented 5 years ago

Relevant for https://github.com/nubark/facturark/pull/20/commits/efe007fc98d3ecd4f35b74fff5575cc994f9407a

tebanep commented 5 years ago

I think we could safely downgrade those dependencies. I'll check tomorrow and make a pull request.

tebanep commented 5 years ago

I think we could safely downgrade those dependencies. I'll check tomorrow and make a pull request.

tebanep commented 5 years ago

I think we could safely downgrade those dependencies. I'll check tomorrow and make a pull request.