knowitall / srlie

The SRL-based Open IE extractor. A principal component of Open IE 4.0.
Other
19 stars 9 forks source link

Index OOB exception #2

Closed rbart closed 11 years ago

rbart commented 11 years ago

Should be able to recreate it by pasting the following sentence into nlpweb:

Having trouble catching up with all the stalking after your two days of socialising (i.e. getting greeked)?

Error message returned is "String index out of range: -7"

schmmd commented 11 years ago

Very cool! Thank you.

schmmd commented 11 years ago

Interestingly, this test case passes. Did you get this exception outside of nlpweb?

  expectedExtractions(
    sentence = "Having trouble catching up with all the stalking after your two days of socialising (i.e. getting greeked)?",
    dgraphString = "dobj(Having_VBG_0_0, trouble_NN_1_7); prep(Having_VBG_0_0, after_IN_8_49); punct(Having_VBG_0_0, ?_._19_106); partmod(trouble_NN_1_7, catching_VBG_2_15); partmod(trouble_NN_1_7, greeked_VBN_17_98); prt(catching_VBG_2_15, up_RP_3_24); prep(catching_VBG_2_15, with_IN_4_27); pobj(with_IN_4_27, stalking_NN_7_40); predet(stalking_NN_7_40, all_PDT_5_32); det(stalking_NN_7_40, the_DT_6_36); pobj(after_IN_8_49, days_NNS_11_64); poss(days_NNS_11_64, your_PRP$_9_55); num(days_NNS_11_64, two_CD_10_60); prep(days_NNS_11_64, of_IN_12_69); pobj(of_IN_12_69, socialising_NN_13_72); punct(greeked_VBN_17_98, _-LRB-_14_84); advmod(greeked_VBN_17_98, i.e._FW_15_85); auxpass(greeked_VBN_17_98, getting_VBG_16_90); punct(greeked_VBN_17_98, _-RRB-_18_105)",
    frameStrings = Seq("have_0.03:[A1=trouble_1, AM-TMP=after_8]",
        "catch_2.04:[C-V=up_3, A2=with_4, AM-TMP=after_8]",
        "get_16.03:[AM-DIS=i.e._15, A2=greeked_17]",
        "greeked_17.01:[AM-ADV=i.e._15]"),
    expectedExtractions = Seq())
schmmd commented 11 years ago

Do you serialize and then deserialize the dependency graph?

rbart commented 11 years ago

Yes, it happens on a small fraction of sentences (1/1000?) while running SrlExtractor over Web input from the KBP corpus.

The dependency graph isn't serialized/deserialized at the point in my code where the error occurred.

schmmd commented 11 years ago

It appears this is already fixed in 1.0.0-RC2.