search

knowitall / taggers

Easily identify and label sentence intervals using various taggers.
11 stars 12 forks source link

Replacement regex bug fix #17

Closed jgilme1 closed 11 years ago

schmmd commented 11 years ago

Pretty sure this fixes it?

jgilme1 commented 11 years ago

Pretty sure, tests passed and and I looked at the replacement output, looks correct, I'll look more deeply for a few more minutes.

schmmd commented 11 years ago

Cool. You don't have to, but I find it helpful to create issues with examples. Otherwise I lose them.

On Thu, Oct 3, 2013 at 3:09 PM, John Gilmer notifications@github.comwrote:

Pretty sure, tests passed and and I looked at the replacement output, looks correct, I'll look more deeply for a few more minutes.

— Reply to this email directly or view it on GitHubhttps://github.com/knowitall/taggers/pull/17#issuecomment-25662575 .

schmmd commented 11 years ago

issues/test cases

On Thu, Oct 3, 2013 at 3:18 PM, Michael Schmitz schmmd@cs.washington.eduwrote:

Cool. You don't have to, but I find it helpful to create issues with examples. Otherwise I lose them.

On Thu, Oct 3, 2013 at 3:09 PM, John Gilmer notifications@github.comwrote:

Pretty sure, tests passed and and I looked at the replacement output, looks correct, I'll look more deeply for a few more minutes.

— Reply to this email directly or view it on GitHubhttps://github.com/knowitall/taggers/pull/17#issuecomment-25662575 .