Added an overloaded method tag to TaggerColelction that takes a string a...

knowitall / taggers

Easily identify and label sentence intervals using various taggers.

11 stars 12 forks source link

Added an overloaded method tag to TaggerColelction that takes a string a... #18

Closed jgilme1 closed 11 years ago

jgilme1 commented 11 years ago

...s an argument

schmmd commented 11 years ago

Hi John, great overall but I have a few comments inline.

jgilme1 commented 11 years ago

Thanks for the comments, here is the revised version.

jgilme1 commented 11 years ago

Thanks for that, looks much better now.

schmmd commented 11 years ago

More than looks, if someone changes tags(tokens: Lemmatized[...]) we get the benefit in tags(sentence: String) too. I can't tell you how many times I've copied code and only changed one implementation.