search

knowitall / taggers

Easily identify and label sentence intervals using various taggers.
11 stars 12 forks source link

Use Sentence representation #20

Closed schmmd closed 10 years ago

schmmd commented 11 years ago

I moved the taggers project forward to use a Sentence representation. I had some interesting problems with the constraints on taggers w.r.t. co/contra variance. I reworked this by making a ConstrainedTagger and now the code is much simpler (and it also compiles). One scary part is that when you deserialize taggers from strings, you can cast them to a bad type. I.e. you could cast a PatternTagger to a Tagger[Sentence].

schmmd commented 11 years ago

@rbart @jgilme1 have a look. It's hot off the press so it might need modifications. I have a few minutes left today to look it over.