search

knowitall / taggers

Easily identify and label sentence intervals using various taggers.
11 stars 12 forks source link

Added a Map from group names to matching strings on the Type class #4

Closed jgilme1 closed 11 years ago

schmmd commented 11 years ago

Hmm... I'll need to think about this. Maybe we can talk about it tomorrow at 9:30.

schmmd commented 11 years ago

Would it work instead of a PatternTagger with descriptor PT would also create types for each group? I.e. if there are named groups G1 and G2 then named groups would turn into PT.G1 and PT.G2?

jgilme1 commented 11 years ago

I'm confused. Would PT.G1 and PT.G2 be Type objects?

schmmd commented 11 years ago

Yes. So the PT tagger would make 3 different types. I don't like adding functionality to Type that only pertains to the PatternTagger.

jgilme1 commented 11 years ago

Ok, I see. Could there be a different way to give a Type from a PatternTagger access to its named Groups or will they only be associated by the descriptor String?

schmmd commented 11 years ago

will they only be associated by the descriptor String?

That is my goal--but maybe it's insufficient. I'd love to hear why.

schmmd commented 11 years ago

We came to an agreement of making the PatternTagger return a subtype of Type called GroupedType, so I'm not merging this preq.