search

knowledge-graphs-tutorial / examples

Examples from knowledge graphs tutorial paper
Creative Commons Zero v1.0 Universal
72 stars 7 forks source link

figure8.shex: Constraints on Event's :start and :end seems wrong. #2

Closed lschmelzeisen closed 3 years ago

lschmelzeisen commented 3 years ago

Figure 8 of the paper (section 2.3.1) depicts the following shape diagram:

shapes-uml

That is, for the Event shape exactly one start and end time should be present.

However, the example currently only specifies these properties as optional.

https://github.com/knowledge-graphs-tutorial/examples/blob/37cc7fda85450d9caec87a946acac98d46e74b5b/Section2/2_3_1_Shapes_graphs/figure8.shex#L13-L14

Since I'm not well-versed in ShEx I can't make this change myself, but it would be nice if someone could take a look at it.

labra commented 3 years ago

Ops, you are right!, I will change that, thanks 👍

lschmelzeisen commented 3 years ago

Seems to have been addressed by 16b74d97482961be8c5adc87043a629526f6cada.