knowledgecommonsdc / kcdc3

Django/Python software to run a free school.
http://knowledgecommonsdc.org
MIT License
4 stars 5 forks source link

Waitlists do not behave entirely correctly #8

Closed adavidramos closed 11 years ago

adavidramos commented 12 years ago

People can join waitlists even when waitlists are turned off. Sometimes? See test results from H.:

turned OFF wait list for Test Class With Five Slots to test behavior when a class is full.

Created user Sarah Jane Smith using admin tool.

The class page still has the Join Waitlist button. (Button works, sends two confirmations, etc.) Logged out, checked admin tool as myself, wait list is indeed off, logged back in as SarahJane, still see wait list button.

And also, other wonky things happen when admins change the size of classes:

I turned wait list back on for Test With Five Slots, then changed the number of students from 5 to 4. Five were enrolled. It showed Sarah Jane, the most recent user, as cancelled AND on the wait list. (No emails were sent.) Then I reduced it to 3, and it added a null registration with None as the date registered. So: People should NOT do that!