knowledgepixels / nanodash

A web client to browse and publish nanopublications.
GNU Affero General Public License v3.0
26 stars 2 forks source link

Bug: "publish another one" copies contents for updates #102

Closed Ostrzyciel closed 9 months ago

Ostrzyciel commented 10 months ago

To reproduce:

The result should be a clean form with the same template. Instead, the template is pre-filled with the content of the previous nanopub. I think this is because the supersede URL parameter is mistakenly carried over.

I would classify this as a "minor annoyance" – it's easy to walk around, but it may confuse users.

tkuhn commented 10 months ago

Yes, good point, thanks for reporting!

For other params, it makes sense at least in some situations for them to be carried over. But I agree that it doesn't make sense in this case and is confusing for users.

I am only thinking right now whether supersede is the only param that should be blocked. For derive, one could argue this to be a feature rather than a bug (if someone want to derive multiple nanopubs from a given one), and even more so for the param_... arguments to fill in certain parts of the form...

Maybe just filtering out supersede is a good first step.

Later, if we find a user-friendly way to present it, there could be two buttons, one for the plain template and one for the template with params applied (the latter disabled for supersede).

Ostrzyciel commented 10 months ago

Agreed! I think the approach with two buttons would be ideal :)

tkuhn commented 9 months ago

Fixed with 01cbe533d380a1aac41d0304f38ad12e9b7641a1. (not yet live)

tkuhn commented 9 months ago

Now live at https://nanodash.petapico.org/