search

knowledgesystems / pipelines-scrum

Repository for tracking uncategorizable issues related to backend pipelines work
0 stars 0 forks source link

Have Backend Approval for SV PR #876

Closed averyniceday closed 2 years ago

averyniceday commented 2 years ago

Done Condition (What do we need? Why do we need it? Keep this is small as possible!)

Sit down with Rob and go through the entire rebased PR to get final approval

cbioportal PR: https://github.com/cBioPortal/cbioportal/pull/9459

cmo-pipelines PR: https://github.com/knowledgesystems/cmo-pipelines/pull/929 https://github.com/knowledgesystems/cmo-pipelines/pull/931

pipelines PR: https://github.com/knowledgesystems/pipelines/pull/445

fallback image: sv-public-push current image: sv-public-push-v2.0

GNAP hash for building importer: 1b2a3675636f3c1a552e53d0584e4d3bd59a7a68 Deployed as HGNC Importer

Technical Description (How are we going to achieve the above)

Potential Issues

Dependencies

Technical Requirements

Outside People/Teams

Changes

sheridancbio commented 2 years ago

The code currently looks good, but requires updates to the documentation (FileFormats) and to the python validator before it can be approved/merged. Notes are added to the PR in comments.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.