knowledgevis / miqa-annotate

A Medical Imaging Annotation Tool
https://annotate.knowledgevis.com
Apache License 2.0
2 stars 0 forks source link

Frontend Prep and Updates #10

Closed davidshq closed 1 year ago

davidshq commented 1 year ago

Upgrade Dependencies

ControlPanel.vue

TypeScript

Vuex

Other

davidshq commented 1 year ago

Re: cross-browser testing

I agree it would be better if we ran the tests cross-browser - but it does take around 3x as long as running through a single test. This isn't a big deal in the CI but it starts to get onerous when doing local dev. That said, there may be a way to configure it so that it runs single browser on local and cross-browser for CI.

This is the first project I'm using Playwright on, so it's likely I don't know all the ins-and-outs and this situation seems like a common scenario.

annehaley commented 1 year ago

Disabling the pyppeteer tests and running a playwright test for one browser is acceptable for now. Could you make this change and make an issue to address the browser testing migration in the future?

annehaley commented 1 year ago

@davidshq Do you mind if I merge this? I'd like to propagate it to the main repo.

davidshq commented 1 year ago

Go for it!

On Fri, Apr 21, 2023 at 12:08 PM Anne Haley @.***> wrote:

@davidshq https://github.com/davidshq Do you mind if I merge this? I'd like to propagate it to the main repo.

— Reply to this email directly, view it on GitHub https://github.com/knowledgevis/miqa-annotate/pull/10#issuecomment-1518047212, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5DQLTSYINV2XZJMFVWV5DXCKWI3ANCNFSM6AAAAAAWVWYB2I . You are receiving this because you were mentioned.Message ID: @.***>