search

knowledgevis / miqa-annotate

A Medical Imaging Annotation Tool
https://annotate.knowledgevis.com
Apache License 2.0
2 stars 0 forks source link

Bring new "dynamic settings" capability into KnowledgeVis repository #4

Open curtislisle opened 1 year ago

curtislisle commented 1 year ago

Bring in the improvements to add dynamic settings via Pull Request into this repository

davidshq commented 1 year ago

We've now merged two PRs into miqa-annotate: https://github.com/knowledgevis/miqa-annotate/pull/9 https://github.com/knowledgevis/miqa-annotate/pull/10

There is a third awaiting review: https://github.com/knowledgevis/miqa-annotate/pull/12

I feel pretty good about this one as most of the changes are comparatively minor.

Once that has been merged I have one more set of code changes to import and then I believe dynamic settings will be fully integrated into miqa-annotate. The code changes have already been made and can be seen in the dynamic-settings branch: https://github.com/davidshq/miqa/tree/dynamic-settings

curtislisle commented 1 year ago

Thanks, Dave. I look forward to looking at these changes and testing out the annotation system.

On Wed, Apr 26, 2023 at 12:00 PM Dave Mackey @.***> wrote:

We've now merged two PRs into miqa-annotate:

9 https://github.com/knowledgevis/miqa-annotate/pull/9

10 https://github.com/knowledgevis/miqa-annotate/pull/10

There is a third awaiting review:

12 https://github.com/knowledgevis/miqa-annotate/pull/12

I feel pretty good about this one as most of the changes are comparatively minor.

Once that has been merged I have one more set of code changes to import and then I believe dynamic settings will be fully integrated into miqa-annotate. The code changes have already been made and can be seen in the dynamic-settings branch: https://github.com/davidshq/miqa/tree/dynamic-settings

— Reply to this email directly, view it on GitHub https://github.com/knowledgevis/miqa-annotate/issues/4#issuecomment-1523669102, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQNT5Q5KYZ4KBK6L626URDXDFBC3ANCNFSM6AAAAAAWNYLJRE . You are receiving this because you authored the thread.Message ID: @.***>

davidshq commented 1 year ago

The last of the annotation system edits are in https://github.com/knowledgevis/miqa-annotate/pull/15

This PR is good to go except there is a problem with the CI, for some reason it can't find ITK. Once this has been resolved it can be merged.