search

knowm / XChange

XChange is a Java library providing a streamlined API for interacting with 60+ Bitcoin and Altcoin exchanges providing a consistent interface for trading and accessing market data.
http://knowm.org/open-source/xchange/
MIT License
3.82k stars 1.93k forks source link

Build failed #1734

Closed e1ektr0 closed 6 years ago

e1ektr0 commented 6 years ago

I'm using https://jitpack.io for cmpile project, and it's failed: (https://jitpack.io/com/github/timmolter/XChange/7c3ca254fd/build.log)

[ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /home/jitpack/build/xchange-yobit/src/main/java/org/knowm/xchange/yobit/YoBitAdapters.java:[134,18] cannot find symbol symbol: method join(java.lang.String,java.util.List) location: class java.lang.String

As i undestad problem with String.join("-", pairs)

What should i do? Wait while some one fixed it or create pull request for fix or change java compile version?

npomfret commented 6 years ago

What JVM are you using?

e1ektr0 commented 6 years ago

As i say, i build it with jitpack io. And as i undestand, it using maven-compiler-plugin 1.7, cose this version set in pom.xml

timmolter commented 6 years ago

Is String.join() Java 8? If so that should be replaced.

e1ektr0 commented 6 years ago

Yes, it's java 8. Should i create a pull request for it, or better wait while some one fix it, coze i'm not good in java :-)

npomfret commented 6 years ago

That was probably me. I'd accidentally commit some java 8 stuff but thought i'd removed it. The build went green I'm sure.

npomfret commented 6 years ago

https://github.com/timmolter/XChange/pull/1736

timmolter commented 6 years ago

It's strange to me that Travis CI and my IDEs (Eclipse and Intellij) didn't catch this issue because the JRE is defined as 1.7 in the pom.xml. I'm using JDK 8, but it used to work fine and catch these issues.