Bitcoin SV support - Githubissues

knowm / XChange

XChange is a Java library providing a streamlined API for interacting with 60+ Bitcoin and Altcoin exchanges providing a consistent interface for trading and accessing market data.

http://knowm.org/open-source/xchange/

MIT License

3.87k stars 1.94k forks source link

Bitcoin SV support #2880

Open PavelNiedoba opened 5 years ago

PavelNiedoba commented 5 years ago

BSV is listed on kraken, BCHSV on poloniex, we need new Currency constant to support it

walec51 commented 5 years ago

I don't think a constant will solve the problem o various ticker names in circulation, especially when you take also BCC, BCH, BABC into consideration: https://github.com/knowm/XChange/issues/2394

PavelNiedoba commented 5 years ago

I understand, but it's been solved before, like krakens xbt

On Mon, 7 Jan 2019, 20:08 Adam Walczak <notifications@github.com wrote:

I don't think a constant will solve the problem o various ticker names in circulation, especially when you take also BCC, BCH, BABC into consideration: #2394 https://github.com/knowm/XChange/issues/2394

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/knowm/XChange/issues/2880#issuecomment-452046135, or mute the thread https://github.com/notifications/unsubscribe-auth/AGvJK9xMEU8DbzSxv3wvpQvv-6WCsDImks5vA5s_gaJpZM4ZI6KE .

geck64 commented 3 years ago

Hello,

I also have the same problem : org.knowm.xchange.exceptions.ExchangeException: Kraken does not support the currency code BSV at org.knowm.xchange.kraken.KrakenUtils.translateKrakenCurrencyCode(KrakenUtils.java:103) ~[xchange-kraken-5.0.5-SNAPSHOT.jar:?]

PavelNiedoba commented 3 years ago

Nice to see this issue still here. In fact the currency don't need to be explicitly harcoded in Currency class to get it work. @geck64 this error is probably that kraken delisted bsv. It was there before, so you may still have bsv transactions in your history. translateKrakenCurrencyCode should recognize bsv thought. It's better co create new issue for that.