search

knowm / XChange

XChange is a Java library providing a streamlined API for interacting with 60+ Bitcoin and Altcoin exchanges providing a consistent interface for trading and accessing market data.
http://knowm.org/open-source/xchange/
MIT License
3.87k stars 1.94k forks source link

Implement Huobi #289

Closed ObsessiveOrange closed 10 years ago

ObsessiveOrange commented 10 years ago

Since users of the XChange library are quite possibly looking at automated trading, and a market with high volume would be ideal, could you please consider adding Huobi. It's not ideal; being in CNY and all, but it would open options.

Trade API: http://www.huobi.com/help/index.php?a=api_help Quotes API: http://www.huobi.com/help/index.php?a=market_help

Cheers.

timmolter commented 10 years ago

Considered. Would be nice to have, I agree.

jheusser commented 10 years ago

Agreed @ObsessiveOrange would be great to have. Had a brief look at their API and it looks relatively straightforward apart from some translation issues. Would be happy to assist in an implementation.

ObsessiveOrange commented 10 years ago

The one thing that I noticed that's odd is that I couldn't find any api call to get a sizable amount of past trades. There's only call that returns any past trades returns 15 trades. hardly enough.

I sent an email about 3 weeks back, to the person who runs bitcoinWisdom, since they DO have all the trades data, to ask what API call they're using, but so far, no response.

I also found a link that we can GET orderbook data from, but it's not published as part of the API docs. (http://market.huobi.com/staticmarket/depth.html)

Thoughts for a workaround?

jheusser commented 10 years ago

Just had a look and that does seem weird. So the call: http://market.huobi.com/staticmarket/detail.html

only returns 15 elements under the trades key, which is really not a lot. I don't think this is a too big limitation though as I can imagine there could be (or will be in the future) a way or parameter to tweak how many trades you receive, for the API implementation this does not matter too much. You will just have to poll that call more frequently if you need it :)

ObsessiveOrange commented 10 years ago

Yeah. It's also unfortunate that you'll be getting a whole bunch of unrelated data just for those 15 trades.

In any case, I'm not free for the next two months or so. I doubt i'll be able to squeeze it in. If nobody's picked this up when my exams finish, I'll jump back on it.

ObsessiveOrange commented 10 years ago

Hmm. So with all the uncertainty about BTC in China, I don't think implementing this is worth as much anymore. I've lost interest in using Huobi for trading. I'll close this for now, and maybe if there's still a lot of interest from others, we can open it again.

jheusser commented 10 years ago

Makes sense. Connectivity/latency to China is pretty bad as well.