knowm / XChange

XChange is a Java library providing a streamlined API for interacting with 60+ Bitcoin and Altcoin exchanges providing a consistent interface for trading and accessing market data.
http://knowm.org/open-source/xchange/
MIT License
3.81k stars 1.93k forks source link

[Binance] UserReference / ClientID not populated in Trades or Orders properly #4825

Open virtex-br opened 4 months ago

virtex-br commented 4 months ago

Binance sends Client Order IDs back on Order Updates. The field is decoded properly, then dropped when creating a new UserTrade. [https://binance-docs.github.io/apidocs/spot/en/#payload-order-update]

The field is copied to a Flag when populating an Order object, but not to the userReference field as it should be