search

knowm / XChange

XChange is a Java library providing a streamlined API for interacting with 60+ Bitcoin and Altcoin exchanges providing a consistent interface for trading and accessing market data.
http://knowm.org/open-source/xchange/
MIT License
3.85k stars 1.94k forks source link

Kraken: add support for OHLC Streaming #4826

Closed rvullriede closed 5 months ago

rvullriede commented 7 months ago

This PR adds support for OHLC Streaming for Kraken. It requires a (backward-compatible) change to NettyStreamingService in order to allow streaming of OHLC for multiple intervals for the same currrency pair. Without this change the channelId won't be unique and interfere with each other.

timmolter commented 5 months ago

If you fix the conflicts, I will merge this.

rvullriede commented 5 months ago

Rebased and fixed conflicts.

timmolter commented 5 months ago

Hello @rvullriede After merging, import info.bitrich.xchangestream.kraken.dto.KrakenStreamingOhlc seems to be missing. Would you kindly take a look?

rvullriede commented 5 months ago

@timmolter, I've pushed the missing class, I got lost during cleaning up my git history. sorry for that.

timmolter commented 5 months ago

ok, thanks. Can you make a new PR?