knowm / XChange

XChange is a Java library providing a streamlined API for interacting with 60+ Bitcoin and Altcoin exchanges providing a consistent interface for trading and accessing market data.
http://knowm.org/open-source/xchange/
MIT License
3.85k stars 1.94k forks source link

[kraken] add different network support for currency deposit addresses #4831

Closed donald-jackson closed 5 months ago

donald-jackson commented 6 months ago

The current implementation doesn't allow for getting addresses with tags (eg XRP) and also if you have currencies with multiple methods (eg USDT, USDC) it is not supported.

This PR introduces a new change to the AccountService interface to allow for more structured complex deposit address requests with a default to the current methods.

It implements this new method on Kraken also inferring the appropriate method where possible with some clear exceptions if it isn't able to do so, so the user can refine their request if desired.