knowm / XChange

XChange is a Java library providing a streamlined API for interacting with 60+ Bitcoin and Altcoin exchanges providing a consistent interface for trading and accessing market data.

http://knowm.org/open-source/xchange/

MIT License

3.81k stars 1.93k forks source link

[binance] Add tickers #4866

Closed bigscoop closed 1 month ago

bigscoop commented 2 months ago

Added mapping symbol -> currency pair (got from exchange info)
Moved exchangeInfo-methods to MarketDataService
Updated integration tests
Added requests for idea http client
Simplified dto's

rizer1980 commented 2 months ago

Hi. Two requests for tickers: api/v3/ticker/price - Latest price for a symbol or symbols. api/v3/ticker/bookTicker - Best price/qty on the order book for a symbol or symbols. But there is no volume and quoteVolume and ticker time is only last moment.

If I understand correctly, we should get a 24 hour ticker. this api is fit: https://binance-docs.github.io/apidocs/spot/en/#24hr-ticker-price-change-statistics

bigscoop commented 2 months ago

Hi. Two requests for tickers: api/v3/ticker/price - Latest price for a symbol or symbols. api/v3/ticker/bookTicker - Best price/qty on the order book for a symbol or symbols. But there is no volume and quoteVolume and ticker time is only last moment.

If I understand correctly, we should get a 24 hour ticker. this api is fit: https://binance-docs.github.io/apidocs/spot/en/#24hr-ticker-price-change-statistics

Hi. Yep, good idea :+1: will change the implementation

rizer1980 commented 2 months ago

done

4868

bigscoop commented 2 months ago

@timmolter

I propose to review and merge the https://github.com/knowm/XChange/pull/4868 first. Then I can integrate the changes to my branch

timmolter commented 2 months ago

merged 4868

bigscoop commented 1 month ago

merged 4868

done, feel free to review

bigscoop commented 1 month ago

@timmolter ping