search

knowm / XChange

XChange is a Java library providing a streamlined API for interacting with 60+ Bitcoin and Altcoin exchanges providing a consistent interface for trading and accessing market data.
http://knowm.org/open-source/xchange/
MIT License
3.81k stars 1.93k forks source link

TradeOgreAdapters.adaptCurrencyPair() build a wrong CurrencyPair #4870

Open francitoshi opened 1 month ago

francitoshi commented 1 month ago

class "TradeOgreAdapters" has the method "adaptCurrencyPair" with

return currencyPair.counter.toString() + "-" + currencyPair.base.toString();

but shoud be

return currencyPair.base.toString() + "-" + currencyPair.counter.toString();

This bug prevents applications from placing an order, with this change the problem it's solved.

gewure commented 1 month ago

please create a PR @francitoshi !

bigscoop commented 1 month ago

it is this one https://github.com/knowm/XChange/pull/4871