search

knowm / XChange

XChange is a Java library providing a streamlined API for interacting with 60+ Bitcoin and Altcoin exchanges providing a consistent interface for trading and accessing market data.
http://knowm.org/open-source/xchange/
MIT License
3.81k stars 1.93k forks source link

Update TradeOgreAdapters.java that is building a reversed CurrencyPair #4871

Open francitoshi opened 1 month ago

francitoshi commented 1 month ago

fix the CurrencyPair that is buiding wrong using COUNTER-BASE and should be BASE-COUNTER

rizer1980 commented 1 month ago

Hello francitoshi As minimum, TestTradeOgreAdapters is failed after your fix. Also, as i think(not sure for 100%), you need to fix adaptTradeOgreCurrencyPair method too. And, if possible, add some test for this fix.