search

knowmetools / km-api

The API behind our Know Me app
Apache License 2.0
4 stars 0 forks source link

Gate ECS IP check behind environment flag #464

Closed cdriehuys closed 5 years ago

cdriehuys commented 5 years ago

Closes #459

Proposed Changes

Instead of always attempting to get the IP address of an ECS task and just continuing if we fail, we now require an environment variable to be set in order for us to get the IP.

The previous behavior was causing the slow CI builds because the network request to get the IP address of the ECS task had to timeout before we could continue and that took approximately 2 minutes per pytest invocation.

codecov[bot] commented 5 years ago

Codecov Report

Merging #464 into master will increase coverage by 0.3%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #464     +/-   ##
=========================================
+ Coverage   97.65%   97.96%   +0.3%     
=========================================
  Files          55       55             
  Lines        1537     1820    +283     
  Branches       86      105     +19     
=========================================
+ Hits         1501     1783    +282     
- Misses         25       26      +1     
  Partials       11       11
Impacted Files Coverage Δ
km_api/km_api/settings.py 62.06% <0%> (-2.77%) :arrow_down:
km_api/know_me/profile/serializers.py 100% <0%> (ø) :arrow_up:
km_api/know_me/profile/views.py 100% <0%> (ø) :arrow_up:
km_api/know_me/profile/urls.py 100% <0%> (ø) :arrow_up:
km_api/know_me/models.py 100% <0%> (ø) :arrow_up:
km_api/know_me/serializers/__init__.py 100% <0%> (ø) :arrow_up:
km_api/know_me/profile/models.py 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77154cb...099e625. Read the comment docs.