search

knownasilya / ember-toggle

Checkbox based Toggle Switches for Ember
http://knownasilya.github.io/ember-toggle/
MIT License
112 stars 52 forks source link

Labels still trigger click action event even when disabled #110

Closed ntgussoni closed 6 years ago

ntgussoni commented 6 years ago

I've been testing this component and it's really nice. However on disabled state, the labels still trigger the action.

I think it's an easy fix. Just checking if disabled=true inside sendToggle method (https://github.com/knownasilya/ember-toggle/blob/master/addon/components/x-toggle/component.js)

What do you think?

111

knownasilya commented 6 years ago

Closed by #111 and released in v5.2.2