search

knownasilya / ember-toggle

Checkbox based Toggle Switches for Ember
http://knownasilya.github.io/ember-toggle/
MIT License
112 stars 52 forks source link

Update ember-cli to 2.11 #62

Closed cibernox closed 7 years ago

knownasilya commented 7 years ago

Ready for merge?

cibernox commented 7 years ago

This fails because the bug present in 2.10+.

I'm actually not sure how to fix it, since seems that the component is doing by design something forbidden, here: https://github.com/knownasilya/ember-cli-toggle/blob/master/addon/components/x-toggle/component.js#L34-L39

This usage (modify one value immediatly when received) was discouraged before but since glimmer2 is just forbidden.

knownasilya commented 7 years ago

Maybe just wrapping it in Ember.run.next?

cibernox commented 7 years ago

Perhaps that could work, although I didn't get exactly why the component wants to immediately set the value on the outside when it's undefined. Shouldn't undefined be treated as falsey and just don't do anything?

knownasilya commented 7 years ago

These are historic changes by @ksnyde, which helped his usecase. Looking back it was probably too specific for the general public. I'd make it simpler and release a 3.0.

LevelbossMike commented 7 years ago

:+1: Thanks for this change. Can we get a patch release for this please? Running into that right now with ember-stable (2.11.0).

knownasilya commented 7 years ago

Released as v3.0.0

LevelbossMike commented 7 years ago

cool thx so much 🍻