(Not only) Bootstrap 4 friendly

[mk-conn]

I was just wondering - Bootstrap 4 is around the corner and the pagination css changed a bit so it would be nice to use the pagination-pager addon with it - to do this, only classnames must be configurable like so (proposal):

´´´ {{pagination-pager current=currentPage pageNumberClass="page-item" pageLinkClass="page-link" // and so on } ´´´ and use this in the pagination-pager.hbs and page-item.hbs. What do you think?

[knownasilya]

I'll take a PR. Once Bootstrap4 is released (non alpha/beta) we can major bump and set the classes to that by default.

[mk-conn]

For now I've just extended the addon components and adjusted the templates which is just fine for me now. Yeh it totally makes sense to wait for BS4 to become final...

[afuno]

@knownasilya So... what? Will Bootstrap 4?

[knownasilya]

Since it's been released, I'd be willing to take a PR if you want to take a stab at it.

[knownasilya]

I'll probably be releasing a version that allows this:

{{#pagination-pager current=current count=count change=(action 'changePage') as |api|}}
  {{#each api.items as |item|}}
    {{#if item.separator}}
      {{item.value}}
    {{else}}
      <a href='?page={{item.value}}' onclick={{action api.onClick item}}>{{item.value}}</a>
    {{/if}}
  {{/each}}
{{/pagination-pager}}

From there I'll export two or more versions: BS3, BS4 and maybe Foundation?

[musaffa]

@knownasilya Any progress? We want to use this addon with BS4.

[knownasilya]

I'll try to take a stab at implementing that lower level API this weekend, allowing anyone else to submit a PR for a BS4 "wrapper" component.