knowndecimal / fulfil

Interact with the Fulfil.io API using Ruby
MIT License
9 stars 2 forks source link

Remove persistent connection and client caching #22

Closed stefanvermaas closed 2 years ago

stefanvermaas commented 2 years ago

This PR deprecates the persistent HTTP connection and removes the caching of the HTTP client used by Fulfil. When using the fulfil gem in background jobs, the caching and the persistent HTTP connection might cause unexpected connection closures.

Setting up new HTTP clients for every request is cheap and thus there is no need for caching it.