knowsys / rulewerk

Java library based on the VLog rule engine
Apache License 2.0
32 stars 13 forks source link

[core] Change reasoner timeout API #24

Open irina-dragoste opened 6 years ago

irina-dragoste commented 6 years ago

Currently, the reasoning timeout can be set in infterface Reasoner, method void setReasoningTimeout(@Nullable Integer seconds). The timeout is currently an Integervalue in seconds, and the default null value represents no reasoning timeout.

To be consistent with OWLReasonerConfiguration timeout ([getTimeOut()](http://soft.vub.ac.be/svn-pub/PlatformKit/platformkit-kb-owlapi3-doc/doc/owlapi3/javadoc/org/semanticweb/owlapi/reasoner/OWLReasonerConfiguration.html#getTimeOut())), we want to change method Reasoner#void setReasoningTimeout(@Nullable Integer seconds) to have:

The new method signature should be: Reasoner#void setReasoningTimeout(long miliseconds)

There should also be getter for the timeout: Reasoner#long getReasoningTimeout()

shade-belisar commented 5 years ago

If nobody is working on this I would assign myself.

irina-dragoste commented 5 years ago

If nobody is working on this I would assign myself.

I am not sure we want to implement this in the near future. It also requires changes in VLog. Will let you know when this task becomes available.