knox-networks / ssi

Rust SSI library that helps developers handle Digital Identity, Verifiable Credentials and Verifiable Presentations.
Apache License 2.0
2 stars 0 forks source link

SSI updates- add bip 39 generation, expose DID generation on header file #135

Closed fkim7 closed 1 year ago

fkim7 commented 1 year ago

part of https://github.com/knox-networks/dart-sdk/issues/62 realized some functions arent exposed in the SSI FFI header file.

Gaps identified so far

Until this is sorted out, Yan is going straight grpc

LuisOsta commented 1 year ago

@fkim7 Currently SSI doesn't support

So we'd have to add that functionality here if we wanted to abstract that away for clients. Would we want add that functionality to SSI? @fkim7 @yanctrindade I'm curious to hear what the benefit is to handle it here vs in Dart. I'm not necessarily against it just curious to hear about what the benefits are.

The rest I think are FFI issues that I'll investigate

fkim7 commented 1 year ago

The idea was that the SSI would be a 1 stop shop for identity, so you just use this 1 SDK for everything identity related and save work for the developers to generate their own SDKs off the protos.. I was looking at the SSI SDK as a generic Knox identity SDK in Rust that can FFI into several languages and save dev time.

LuisOsta commented 1 year ago

Okay sounds good

LuisOsta commented 1 year ago

@fkim7 @yanctrindade For context "DID generation" is already exposed via create_identity and registry_create_did. If that's not the needed functionality let me know what exactly you mean by that

LuisOsta commented 1 year ago

I've created https://github.com/knox-networks/ssi/issues/139 to handle the VC download side of things

fkim7 commented 1 year ago

lets create link account/associate wallet also

yanctrindade commented 1 year ago

@LuisOsta the new KeyParir Struct expose the mnemonic but DidDocument has the DID after create_identity is not accessible since we dont have DidDocument struct exposed on ssi_ffi.h, something else we can do is create a fuction passing the didDocument pointer that returns the pointer.char to did generated. Idk the pros and cons from each approach.

The thing is, If I use only SSI lib I have following use cases

  1. generate bip39 mnemonic and access the 12 words string
  2. Create identity (DidDocumento struct)
  3. registry the identity created (push did doc)

but If I want to access the did itself its not exposed from ssi_ffi.h