search

knpuniversity / behat

Screencast code, script and kittens behind "BDD, Behat, Mink and other Wonderful Things Tutorial"
http://knpuniversity.com/screencast/behat
Other
12 stars 14 forks source link

Code blocks for the ch8 and ch9 #20

Closed bocharsky-bw closed 8 years ago

bocharsky-bw commented 8 years ago

Resolve ch8 and ch9 in #12

weaverryan commented 8 years ago

:+1: a few small changes, but nothing big. The one interesting one is that sometimes its helpful to be able to show code blocks of a vendor class - like MinkExtension. I try not to overdo it (because it's kind of a hack), but in these cases, I commit the vendor file to the master branch (well, behat3 in this case) and in order to use it my code blocks. So, I did that here - and it's ok to do it in the future :).

bocharsky-bw commented 8 years ago

I thought about to add MinkExtension from vendors, but should we add this file to the our VCS?

weaverryan commented 8 years ago

Since the code blocks can only build files that are in the vcs, we must add them. So yes - I added MinkExtension to vcs, which is kind of hacky but ok :)

bocharsky-bw commented 8 years ago

Then maybe we should add a next line to the .gitignore?

/vendor/
!vendor/behat/mink-extension/src/Behat/MinkExtension/Context/Mink/MinkContext.php
weaverryan commented 8 years ago

@bocharsky-bw we could do that - I force added the file anyways - so I don't think this line will make any difference, right?

bocharsky-bw commented 8 years ago

I thought any changes in this file will be ignored by vsc, but seems vsc following its changes, so that's OK.

weaverryan commented 8 years ago

Yep - it won't follow changes, BUT you can override that with a git add -f filename :)

bocharsky-bw commented 8 years ago

Don't know that, thanks! :)