knpuniversity / behat

Screencast code, script and kittens behind "BDD, Behat, Mink and other Wonderful Things Tutorial"
http://knpuniversity.com/screencast/behat
Other
12 stars 14 forks source link

Add code blocks for the ch11 (suites) #24

Closed bocharsky-bw closed 8 years ago

bocharsky-bw commented 8 years ago

Resolve ch11-suites in #12

weaverryan commented 8 years ago

:+1: - nice job including the CommandLineProcessContext to show "all" of it, but try to hide some less important pieces for space. I did change a few code blocks on this one - for behat.yml - sometimes we would hide the default and suites keys, so when you looked at the code-block, the code we showed was kind of floating in the middle of nowhere - the context wasn't obvious enough. Here's an example:

screen shot 2015-11-09 at 6 36 26 pm

If you ever disagree, let me know! We're both 2 developers, finding the perfect balance that we would want included (and either way, it's not a huge deal, since the code blocks expand - yay!) :)

bocharsky-bw commented 8 years ago

:+1: for saving space! Anyways, code blocks really can be expanded if need :)

weaverryan commented 8 years ago

@bocharsky-bw actually, I did the opposite - I added a little bit more code to the screenshot (screenshot was the original) - I changed it to include more lines by default :innocent:

bocharsky-bw commented 8 years ago

Oh, I understood an idea wrong :)

I shorten it sometimes.. I'll try to add more context in such cases.