knpuniversity / behat

Screencast code, script and kittens behind "BDD, Behat, Mink and other Wonderful Things Tutorial"
http://knpuniversity.com/screencast/behat
Other
12 stars 14 forks source link

Add code blocks to the ch13 (control-database) #26

Closed bocharsky-bw closed 8 years ago

bocharsky-bw commented 8 years ago

Resolve ch13-control-database in #12

bocharsky-bw commented 8 years ago

For this chapter the difference is: ThereIsAnAdminUserWithPassword() in the screencast and ThereIsAUserWithPassword() in the code blocks. Does it very bad here? Should we change it in source code?

weaverryan commented 8 years ago

I think we should change this one - seem just important enough. Are you able to make that change? If you are, do it for this PR :)

bocharsky-bw commented 8 years ago

@weaverryan I tried to do it but I'm not sure that it happened. There're my steps:

I did something wrong?

weaverryan commented 8 years ago

@bocharsky-bw I think you're really close - it's a little tricky, especially to do it on a branch. I think these are the correct steps:

Now, to actually update the code block, you'll need to go into the code block gui and change the sha to be the latest sha on your code-blocks-ch13 branch. That will allow the code blocks gui to see your latest code changes.

I'd revert your changes to _tuts/steps.json before trying this - and maybe also run tuts2 reset on the behat3 branch to "clear out all the branches". Ultimately, this PR should have changes to _tuts/steps.json and at least one .diff file in _tuts/.

Let me know if that makes sense! It's still a very technical and delicate tool - especially when working not on the master/behat3 branch.

bocharsky-bw commented 8 years ago

Yeah, it works! Seems the problem was that I did checkout back to the code-blocks-ch13 before running tuts compile. But there're a lot of file was changed in _tuts... I think it's correct, right?

weaverryan commented 8 years ago

:+1: Yes, it's because the sha is stored in the diff's, which we really don't need. Diffs are still quite a mysterious (and delicate) thing - I'd like to learn more about them and see if the sha's can be removed from those files.