Add certificate support for Azure provider

knpuniversity / oauth2-client-bundle

Easily talk to an OAuth2 server for social functionality in Symfony

https://symfonycasts.com

MIT License

787 stars 145 forks source link

Add certificate support for Azure provider #379

Closed uncaught closed 2 years ago

uncaught commented 2 years ago

Adds certificate support to the Azure provider:

Makes configuration option client_secret optional
Adds configuration options client_certificate_private_key and client_certificate_thumbprint

See https://github.com/TheNetworg/oauth2-azure/pull/170 (merged) for the respective PR on the provider.

That PR is not released, yet, but there are no compatibility issues with this PR here. They can be installed independently without drawbacks.

Only to actually use certificates you had to have both PRs merged/released/installed.

weaverryan commented 2 years ago

This looks good to me - except two little code styling things to run:

A) php-cs-fixer fix --verbose --diff (once you have php-cs-fixer installed - you could even temporarily composer require it locally into this repo then just not commit the composer changes)

B) bin/update_readme - to regenerate part of the README

Cheers!

weaverryan commented 2 years ago

Thanks @uncaught!

uncaught commented 2 years ago

All green :) Is there something else missing?

weaverryan commented 2 years ago

Thanks for the poke - this DID get merged in with a rebase... and for some reason my system didn't close the PR. It's all good and in!

quentinRogeret34 commented 2 years ago

Hello @weaverryan , I am really interested in this feature. Do you know when you are going to release?

Thanks 🙏

uncaught commented 2 years ago

Hello @weaverryan , I am really interested in this feature. Do you know when you are going to release?

Thanks 🙏

Bare in mind, that https://github.com/TheNetworg/oauth2-azure/pull/170 hasn't been released, yet, either. So you could install that repository from master or had to wait for their release, too.